Implement mismatched_target_os lint #5506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
reviewed
Apr 24, 2020
phansch
added
the
S-waiting-on-author
ebroto
force-pushed
the
mismatched_target_os
branch
from
dfa13ab to
be57434
Compare
flip1995
reviewed
Apr 25, 2020
ebroto
force-pushed
the
mismatched_target_os
branch
from
be57434 to
da6a5d3
Compare
|
Oh, I was not aware of the stderr line limit. I guess I can remove some OS from the unix group as all of them are in the same slice in the end... |
|
I would suggest to keep tests for every OS, but split up the tests in unix and non-unix. This should meet the line limit of 200. |
- Show just one error message with multiple suggestions in case of using multiple times an OS in target family position - Only suggest #[cfg(unix)] when the OS is in the Unix family - Test all the operating systems
ebroto
force-pushed
the
mismatched_target_os
branch
from
67da32e to
303e7d1
Compare
Yeah, that's way better :) Thanks for this and all your other suggestions! |
|
@bors r+ Thanks! Great lint. |
|
📌 Commit 303e7d1 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extended the check suggested in the issue to all the currently supported operating systems instead of limiting it to
linuxandmacos, let me know if we want to do this.Also, I've restored the text
There are over XXX lints ...in the README as it was matched against bycargo dev new_lint.changelog: Added
mismatched_target_oslint to warn when an operating system is used in target family position in a #[cfg] attributeCloses #3949